Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourmash-minimal v4.8.5 #55

Merged
merged 9 commits into from
Dec 16, 2023
Merged

sourmash-minimal v4.8.5 #55

merged 9 commits into from
Dec 16, 2023

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Dec 13, 2023 •
edited by ctb
Loading

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7188909933, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ctb ctb mentioned this pull request Dec 13, 2023
Closed
@ctb
Copy link
Contributor

ctb commented Dec 13, 2023

@conda-forge-admin, please rerender

@luizirber
Copy link
Contributor

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits December 14, 2023 23:51
luizirber
luizirber reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling attention from @conda-forge/core due to requiring a newer macos SDK

recipe/conda_build_config.yaml
Comment on lines +1 to +4
MACOSX_SDK_VERSION: # [osx and x86_64]
- "10.14" # [osx and x86_64]
MACOSX_DEPLOYMENT_TARGET: # [osx and x86_64]
- "10.14" # [osx and x86_64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to match minimal deployment target supported by rocksdb, and mirroring what rocksdb-feedstock does

recipe/meta.yaml
Comment on lines +55 to +56
# Due to rocksDB: https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
- __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }} # [osx and x86_64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rocksdb-feedstock is missing this one, but this is suggested in the conda-forge docs

recipe/patches/0001-fix-deployment-target.patch
Comment on lines +9 to +10
-macos-deployment-target = "11.0"
+macos-deployment-target = "10.14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed upstream and removed on the next conda-forge release

@ctb ctb mentioned this pull request Dec 15, 2023
Open
@luizirber
Copy link
Contributor

bioconda/bioconda-recipes#44784 was successful and used 4.8.5 pulled from conda-forge (how?!?!??! it is indeed available when searching...), so merging this before it becomes more confusing 😅

@luizirber luizirber merged commit c2d32e8 into conda-forge:main Dec 16, 2023
20 checks passed
@luizirber luizirber mentioned this pull request Dec 16, 2023
Closed
1 task
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 4.8.5_hd849e2 branch December 16, 2023 22:29
@mbargull
Copy link
Member

bioconda/bioconda-recipes#44784 was successful and used 4.8.5 pulled from conda-forge (how?!?!??! it is indeed available when searching...), so merging this before it becomes more confusing 😅

Oh no, my bad!
I ran a new pipeline for this branch to test out whether we get reasonable CI time with conda-build=3.27 for this one.
(conda-build=3.28.0/conda-build=3.28.1 had a bug which prolonged the build time significant; multiple hour added in case of sourmash-minimal.)
... I didn't realize that it count my pipeline as a non-PR build and uploaded the packages 🙈.
Sorry about that hiccup!

@luizirber
Copy link
Contributor

Oh no, my bad! I ran a new pipeline for this branch to test out whether we get reasonable CI time with conda-build=3.27 for this one. (conda-build=3.28.0/conda-build=3.28.1 had a bug which prolonged the build time significant; multiple hour added in case of sourmash-minimal.) ... I didn't realize that it count my pipeline as a non-PR build and uploaded the packages 🙈. Sorry about that hiccup!

Mistery solved, thanks @mbargull!

I was worried with the build times on this one, it is still pretty high... Thinking about doing only the Python extension and stopping with the shared/static builds for C/C++ linking, because I don't think anyone is using that. That would pretty much reduce build time by 50%

@luizirber luizirber mentioned this pull request Dec 17, 2023
Merged
luizirber added a commit to sourmash-bio/sourmash that referenced this pull request Dec 17, 2023
@luizirber
CI: macos deployment target and maturin updates (#2879)
94b3631 
- macOS fixes from
conda-forge/sourmash-minimal-feedstock#55
- bump maturin to 1.4.0
- use maturin-action for linux `aarch64` and `ppc64le` (`s390x` is still
annoying to get right) and windows (turns out it just works)
This was referenced Dec 18, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizirber luizirber luizirber left review comments

@ctb ctb ctb approved these changes

@bluegenes bluegenes Awaiting requested review from bluegenes bluegenes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@regro-cf-autotick-bot @ctb @luizirber @mbargull