Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for libignition-utils1 #14446

Merged
merged 8 commits into from
Apr 1, 2021
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 1, 2021

Fix #13551 . This adds the Ignition Utils library, the last maintained Ignition library that is missing from conda-forge. This includes the change proposed upstream in gazebosim/gz-utils#19 to avoid vendoring cli11 .

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libignition-utils1) and found it was in an excellent condition.

@traversaro traversaro changed the title [WIP] Add recipe for libignition-utils1 Add recipe for libignition-utils1 Apr 1, 2021
@traversaro
Copy link
Contributor Author

This should unblock conda-forge/libignition-common-feedstock#29 and several other update PRs for other Ignition Libraries.

@traversaro
Copy link
Contributor Author

@conda-forge/help-c-cpp @wolfv the PR is ready for review

@wolfv wolfv merged commit 9148637 into conda-forge:master Apr 1, 2021
@traversaro traversaro deleted the patch-6 branch April 1, 2021 09:04
@wolfv
Copy link
Member

wolfv commented Apr 1, 2021

awesome. Just a little side-note: cli11 has unfortunately not seen a release in a while. not sure if the latest release is vendored or some more recent version branched off of "master"... (we're actually vendoring cli11 from master in micromamba because it has some improvements that we wanted).

@traversaro
Copy link
Contributor Author

awesome. Just a little side-note: cli11 has unfortunately not seen a release in a while. not sure if the latest release is vendored or some more recent version branched off of "master"... (we're actually vendoring cli11 from master in micromamba because it has some improvements that we wanted).

I checked, cli11 1.9.1 is vendored in ignition-utils : https://github.com/ignitionrobotics/ign-utils/blob/main/cli/README.md .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add recipes for missing ignition libraries
3 participants