Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add awscrt #14664

Merged
merged 4 commits into from
Jun 15, 2021
Merged

add awscrt #14664

merged 4 commits into from
Jun 15, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 21, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/awscrt) and found it was in an excellent condition.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 21, 2021

    --- Building dependency: aws-lc (RelWithDebInfo) ---
    /home/conda/staged-recipes/build_artifacts/awscrt_1619035367907/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/bin/cmake -DCMAKE_PREFIX_PATH=/tmp/pip-req-build-5jfjgulx/build/deps/install -DCMAKE_INSTALL_PREFIX=/tmp/pip-req-build-5jfjgulx/build/deps/install -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTING=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_LIBSSL=OFF /tmp/pip-req-build-5jfjgulx/crt/aws-lc
    CMake Error at CMakeLists.txt:39 (message):
      GCC 9.3.0 is not supported.

😒

@chrisburr
Copy link
Member

Apparently this is intentional to ban this version: https://github.com/awslabs/aws-lc/blob/129fc373c971f6ac275a1ed5de2b96410d9cc9d9/CMakeLists.txt#L31-L42

It should still be possible to use GCC 7 using a conda_build_config.yaml.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 10, 2021

Apparently this is intentional to ban this version: https://github.com/awslabs/aws-lc/blob/129fc373c971f6ac275a1ed5de2b96410d9cc9d9/CMakeLists.txt#L31-L42

It should still be possible to use GCC 7 using a conda_build_config.yaml.

Do you know the right syntax for it? I tried:

ctng_gcc:
  - 7.5.0

but it didn't work.

@xhochy
Copy link
Member

xhochy commented Jun 10, 2021

@ocefpaf Welcome to the world of aws-c-* packages 😍 I will dig a bit into this as it is probably better to use the C(++) packages from conda-forge instead of the bundled sources. For the referenced error, I would suggest a different fix: Find out how to build it without aws-lc. That is AWS' own OpenSSL fork, you should be able to build instead without aws-lc normally and use our openssl package.

@xhochy
Copy link
Member

xhochy commented Jun 10, 2021

Made a PR to your fork: ocefpaf#6 but that depends on #15187 which I can fix tomorrow. It worked fine on osx-arm64 for me :)

Use aws-* libs from conda-forge
@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 10, 2021

Thanks @xhochy!

@xhochy xhochy closed this Jun 11, 2021
@xhochy xhochy reopened this Jun 11, 2021
@xhochy xhochy closed this Jun 11, 2021
@xhochy xhochy reopened this Jun 11, 2021
@xhochy
Copy link
Member

xhochy commented Jun 14, 2021

Depends on conda-forge/aws-c-mqtt-feedstock#8

@xhochy
Copy link
Member

xhochy commented Jun 15, 2021

@conda-forge/staged-recipes With the latest build of aws-c-mqtt this is now ready for review/merge.

@chrisburr chrisburr merged commit 12450e4 into conda-forge:master Jun 15, 2021
@ocefpaf ocefpaf deleted the awscrt branch June 15, 2021 16:30
@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 15, 2021

@xhochy and @chrisburr thanks so much for the help here. I had no idea what I was getting into 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants