Add aicspylibczi recipe

[goanpeca]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[evamaxfield]

Hey @goanpeca thanks taking this on! I think the last discussion of "how to get a conda release of this" someone said we need to add the cmake file to the manifest.ini or something similar?

AllenCellModeling/aicspylibczi#90

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aicspylibczi) and found it was in an excellent condition.

[goanpeca]

Hi @evamaxfield, thanks for the heads up :)

[goanpeca]

We are in the process of creating conda packages for napari plugins and related dependencies. Once this recipe passes all the checks, every time a new release goes into PyPI, a PR will be created automatically, with usually very minor need for changes so the process of maintaining this moving forward is small. Also the @conda-forge/napari team will be available to help as needed.

You can read a bit more about conda-forge at https://conda-forge.org/#contribute

---

@evamaxfield, @toloudis do you agree with being added as maintainers?

[evamaxfield]

I agree to be listed.

May also be good to ask @toloudis

[evamaxfield]

I think the only reason I remembered that cmakelists thing is because Talley tried to do this a few months ago: #16326

[goanpeca]

Ha, yeah some PRs started but stayed like that, I can take over now :)

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aicspylibczi) and found it was in an excellent condition.

[goanpeca]

@evamaxfield, retaking this work. Is the package gpl-3.0-only or gpl-3.0-or-later? Thanks!

[evamaxfield]

Thanks @goanpeca!!

It follows the base libczi library: https://github.com/zeiss-microscopy/libCZI/blob/master/LICENSE

So I assume gpl-3.0-only?

[MaximLippeveld]

@goanpeca Would you consider skipping the win build for now? That way linux only packages could already proceed with this 🙂

[stale]

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

[toloudis]

we are currently revisiting aicspylibczi to try to ensure the full sdist is corrected and support python 3.11.

[goanpeca]

@goanpeca Would you consider skipping the win build for now? That way linux only packages could already proceed with this 🙂

Sure thing :)

[toloudis]

@goanpeca I wonder if you could bump the aicspylibczi version to 3.1.1, which should have a better sdist and also more up to date wheels for Python 3.11 support.
edit I am still testing aicspylibczi 3.1.1 and will post again when I am pretty sure it is stable.

[toloudis]

confirmed, aicspylibczi 3.1.1 is the one that should be used here please.

[goanpeca]

Will update! Thanks for the heads up

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aicspylibczi) and found it was in an excellent condition.

[toloudis]

@goanpeca Can I make some small edits to this PR to see if the build works? version 3.1.2 should now have a sdist that bundles along with its submodule dependencies. Not sure of process, whether the build will automatically happen or needs to be triggered

[jaimergp]

@toloudis, can you add the proposed changes as code review suggestions? We can then commit them from there.

[goanpeca]

@toloudis is this still needed?

[goanpeca]

@toloudis is this still needed?

[toloudis]

@toloudis is this still needed?

Honestly not sure. If I had to guess I would say no, not needed.

[goanpeca]

I ask because of what the readme says

https://github.com/AllenCellModeling/aicspylibczi#build

Build
Use these steps to build and install aicspylibczi locally:

Clone the repository including submodules (--recurse-submodules).
Requirements:
libCZI requires a c++11 compatible compiler. Built & Tested with clang.
Development requirements are those required for libCZI: libpng, zlib

[toloudis]

I haven't confirmed it but the only place our repo explicitly refers to those libs is here:
https://github.com/AllenCellModeling/aicspylibczi/blob/2e2faeefa1e3fea3b0da979db07f85c6be746904/.github/workflows/py-build-main.yml#L106

I believe that might be outdated due to this https://github.com/ZEISS/libczi/blob/134582181b5e121c4a1b0236ae707e2db36f66ff/Src/libCZI/Doc/building_libCZI.markdown?plain=1#L58
(libpng and zlib only needed for czicmd build target which is not required for aicspylibczi ).

However, it doesn't hurt to keep them in?

[goanpeca]

👍🏼

[goanpeca]

This one is ready for review @conda-forge/staged-recipes :)

[jaimergp]

This is running cmake behind the scenes, which relies on a vendored pybind11 submodule and some other stuff. We might need to patch things to make it conda-forge friendly.

[stale]

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!