Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for gz-launch #20749

Merged
merged 11 commits into from
Oct 31, 2022
Merged

Add recipe for gz-launch #20749

merged 11 commits into from
Oct 31, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 13, 2022

The ignition robotics libraries, that are currently packaged in conda-forge under the libignition-*, have been renamed to Gazebo libraries (see https://community.gazebosim.org/t/a-new-era-for-gazebo/1356).

To avoid confusion related to the feedstock name in the future, we are re-submitting all the libignition- recipes to conda-forge to have descriptive and coherent names that start with gz-, as described in conda-forge/libignition-cmake0-feedstock#26 (comment) .

This PR creates a new gz-launch-feedstock to package gz-launch, using the recipe already available in https://github.com/conda-forge/libignition-launch-feedstock .

As discussed in conda-forge/libignition-cmake0-feedstock#26, for consistency with Gazebo/Ignition libraries that have Python bindings also this PRs structured the recipe as a multiple-output one, in which the gz-launch6 package is used to install all the outputs.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gz-launch) and found it was in an excellent condition.

@traversaro traversaro closed this Oct 30, 2022
@traversaro traversaro reopened this Oct 30, 2022
@traversaro
Copy link
Contributor Author

Approval of being mantainers from the mantainers (i.e. GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.)

@conda-forge/help-c-cpp The recipe is ready for review.

@xhochy xhochy merged commit 050cb11 into conda-forge:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants