Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRbeam program #27631

Merged
merged 43 commits into from
Nov 4, 2024
Merged

CRbeam program #27631

merged 43 commits into from
Nov 4, 2024

Conversation

okolo
Copy link
Contributor

@okolo okolo commented Sep 19, 2024

No description provided.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found some lint.

Here's what I've got...

For recipes/crbeam/meta.yaml:

  • requirements: build: gsl==2.6 must contain a space between the name and the pin, i.e. gsl ==2.6
  • requirements: build: boost==1.82.0 must contain a space between the name and the pin, i.e. boost ==1.82.0
  • requirements: host: gsl==2.6 must contain a space between the name and the pin, i.e. gsl ==2.6
  • requirements: host: boost==1.82.0 must contain a space between the name and the pin, i.e. boost ==1.82.0
  • requirements: run: gsl==2.6 must contain a space between the name and the pin, i.e. gsl ==2.6
  • requirements: run: boost==1.82.0 must contain a space between the name and the pin, i.e. boost ==1.82.0
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/crbeam/meta.yaml:

  • The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found some lint.

Here's what I've got...

For recipes/crbeam/meta.yaml:

For recipes/crbeam/meta.yaml:

  • The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found some lint.

Here's what I've got...

For recipes/crbeam/meta.yaml:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.

@volodymyrss
Copy link
Contributor

volodymyrss commented Sep 24, 2024

Maybe we should ask conda-forge maintainers to understand why the build is different from that in local environment.

Also need we need to figure out licensed code in the package.

Copy link

github-actions bot commented Sep 30, 2024

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/staged-recipes/actions/runs/11107381737.

Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 2, 2024

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy
bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge-webservices/actions/runs/11143432183.

@beckermr
Copy link
Member

beckermr commented Oct 2, 2024

@conda-forge-admin relint

recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
@okolo okolo requested a review from xhochy October 20, 2024 04:32
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/crbeam/meta.yaml:

  • You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/crbeam/meta.yaml:

  • You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crbeam/meta.yaml) and found it was in an excellent condition.

@okolo
Copy link
Contributor Author

okolo commented Oct 23, 2024

@xhochy I think the recipe is ready for merge. I have addressed all your suggestions.

@okolo
Copy link
Contributor Author

okolo commented Oct 24, 2024

@conda-forge/help-c-cpp ready for review

@okolo
Copy link
Contributor Author

okolo commented Oct 25, 2024

Please loosen/remove all/most of the pins. Otherwise this package will be incompatible with the rest of the ecosystem.

done

@volodymyrss
Copy link
Contributor

@bgruening FYI, this is need for our ESG work.

Copy link
Contributor

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okolo this looks pretty good! Well done. There is one co fusion about the version. Can you maybe release a.proper 1.1.1 version?

recipes/crbeam/meta.yaml Outdated Show resolved Hide resolved
@bgruening bgruening merged commit d4e4f71 into conda-forge:main Nov 4, 2024
7 checks passed
@bgruening
Copy link
Contributor

Merci!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants