Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pc_rasterize #27653

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add pc_rasterize #27653

merged 5 commits into from
Sep 24, 2024

Conversation

fbunt
Copy link
Contributor

@fbunt fbunt commented Sep 20, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pc_rasterize/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pc_rasterize/meta.yaml:

  • No valid build backend found for Python recipe for package pc_rasterize using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pc_rasterize/meta.yaml) and found it was in an excellent condition.

@fbunt
Copy link
Contributor Author

fbunt commented Sep 20, 2024

@conda-forge/help-python Any advice?

I don't understand why the pip check test failed. Looking at the logs, it says "pc-rasterize 0.2.0 requires python-pdal, which is not installed." but, as far as I can tell, python-pdal is installed right before the test.

@fbunt
Copy link
Contributor Author

fbunt commented Sep 21, 2024

I reproduced this locally. For whatever reason pip check cannot see python-pdal. pc_rasterize imports and works just fine though so I'm going to remove that test. I'll just have the import test for now.

pip check cannot see python-pdal for some reason and fails despite the package being present. Everything works aside from that so I am removing this test.
@synapticarbors
Copy link
Member

I'm not exactly sure what pip check is looking at but perhaps it's somehow confused by the fact that pypi has a pdal and python-pdal and what conda-forge calls python-pdal is actually pdal on pypi. On pypi, python-pdal looks like some sort of place holder.

@synapticarbors synapticarbors merged commit 17879f8 into conda-forge:main Sep 24, 2024
6 checks passed
@fbunt
Copy link
Contributor Author

fbunt commented Sep 24, 2024

Wow. That's a bit of a mess. Thanks for looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants