Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rocksdict as a package #27661

Merged
merged 16 commits into from
Oct 10, 2024
Merged

Added rocksdict as a package #27661

merged 16 commits into from
Oct 10, 2024

Conversation

thewchan
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rocksdict/meta.yaml) and found it was in an excellent condition.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@thewchan
Copy link
Contributor Author

@conda-forge/help-python-c @conda-forge/help-rust I added libclang to build and that made it work for win build, but maybe I need to point to it in some path variable in linux and osx build? Any pointers appreciated here

@xhochy
Copy link
Member

xhochy commented Sep 21, 2024

I have seen this requirement before, but there one needed to put libclang into host.

Copy link

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

Copy link

github-actions bot commented Sep 21, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rocksdict/meta.yaml, recipes/example-v1/recipe.yaml, recipes/example/meta.yaml) and found some lint.

Here's what I've got...

For recipes/example-v1/recipe.yaml:

This is a v1 recipe and not yet lintable. We are working on it!

For recipes/example/meta.yaml:

@thewchan
Copy link
Contributor Author

I have seen this requirement before, but there one needed to put libclang into host.

Thanks @xhochy I'll try that

Comment on lines 25 to 26
- clangdev
- clangxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead add a conda_build_config.yaml with

c_compiler:
  - clang
cxx_compiler:
  - clangxx

If that works, it's probably the more sustainable approach.

Suggested change
- clangdev
- clangxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me try that thanks @xhochy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy no luck; should I add clangdev back to build? Should I leave conda_build_config with clang in or out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm actually the error is something else

  - nothing provides requested clang_linux-64 13.*
  - nothing provides requested clangxx_linux-64 13.*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://conda-forge.org/news/2024/04/30/clang-everywhere/ maybe I need to specify compiler version like it says here?

@beckermr
Copy link
Member

@conda-forge-admin relint

Copy link

github-actions bot commented Sep 23, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rocksdict/meta.yaml) and found it was in an excellent condition.

@beckermr
Copy link
Member

@conda-forge-admin relint

@thewchan
Copy link
Contributor Author

okay, now it's still complaining about not able to find clang, so I think we might have to go with the clangdev in build solution. What do you think @xhochy ?

@thewchan thewchan mentioned this pull request Sep 23, 2024
10 tasks
@xhochy
Copy link
Member

xhochy commented Sep 25, 2024

okay, now it's still complaining about not able to find clang, so I think we might have to go with the clangdev in build solution. What do you think @xhochy ?

Yes, seems like the way forward. I would have liked to avoid it but it seems that is sadly not as straight-forward as hoped.

@thewchan
Copy link
Contributor Author

thewchan commented Oct 4, 2024

@xhochy @conda-forge/staged-recipes @conda-forge/help-python this is ready to be reviewed again!

Copy link

github-actions bot commented Oct 4, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@xhochy xhochy merged commit e0a0ae1 into conda-forge:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants