-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rocksdict as a package #27661
Added rocksdict as a package #27661
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge/help-python-c @conda-forge/help-rust I added |
I have seen this requirement before, but there one needed to put |
Hi! This is the friendly automated conda-forge-linting service. I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/example-v1/recipe.yaml: This is a v1 recipe and not yet lintable. We are working on it! For recipes/example/meta.yaml:
|
Thanks @xhochy I'll try that |
recipes/rocksdict/meta.yaml
Outdated
- clangdev | ||
- clangxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you instead add a conda_build_config.yaml with
c_compiler:
- clang
cxx_compiler:
- clangxx
If that works, it's probably the more sustainable approach.
- clangdev | |
- clangxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me try that thanks @xhochy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhochy no luck; should I add clangdev
back to build? Should I leave conda_build_config
with clang in or out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm actually the error is something else
- nothing provides requested clang_linux-64 13.*
- nothing provides requested clangxx_linux-64 13.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://conda-forge.org/news/2024/04/30/clang-everywhere/ maybe I need to specify compiler version like it says here?
@conda-forge-admin relint |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin relint |
okay, now it's still complaining about not able to find |
Yes, seems like the way forward. I would have liked to avoid it but it seems that is sadly not as straight-forward as hoped. |
@xhochy @conda-forge/staged-recipes @conda-forge/help-python this is ready to be reviewed again! |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).