Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest-ignore-flaky #4513

Closed
wants to merge 6 commits into from
Closed

Add pytest-ignore-flaky #4513

wants to merge 6 commits into from

Conversation

rmcgibbo
Copy link
Contributor

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pytest-ignore-flaky) and found it was in an excellent condition.

- pytest
run:
- python
- pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this package wants pytest >=2.7

build:
- python
- pip
- pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs pytest as a build requirement.

build:
noarch: python
number: 0
script: pip install .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you're going to use pip here it should be:

script: pip install --no-deps .

or possibly:

python -m pip install --no-deps --ignore-installed .

see:
#528

@rmcgibbo
Copy link
Contributor Author

Thanks @synapticarbors.

@synapticarbors
Copy link
Member

This looks ready to merge, but for some reason it's not triggering CircleCI, which we need to see in order to finalize.

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Dec 1, 2017

Is there anything I can do? An empty commit to retrigger?

@synapticarbors
Copy link
Member

Sometimes there is something weird with certain personal accounts and how CircleCI is configured. I just made a copy of your PR in #4516 and it looks like it's running ok, so we can just merge from there.

@rmcgibbo rmcgibbo closed this Dec 1, 2017
@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Dec 1, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants