-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest-ignore-flaky #4513
Add pytest-ignore-flaky #4513
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- pytest | ||
run: | ||
- python | ||
- pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this package wants pytest >=2.7
build: | ||
- python | ||
- pip | ||
- pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs pytest
as a build
requirement.
build: | ||
noarch: python | ||
number: 0 | ||
script: pip install . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you're going to use pip
here it should be:
script: pip install --no-deps .
or possibly:
python -m pip install --no-deps --ignore-installed .
see:
#528
Thanks @synapticarbors. |
This looks ready to merge, but for some reason it's not triggering CircleCI, which we need to see in order to finalize. |
Is there anything I can do? An empty commit to retrigger? |
Sometimes there is something weird with certain personal accounts and how CircleCI is configured. I just made a copy of your PR in #4516 and it looks like it's running ok, so we can just merge from there. |
Thanks. |
No description provided.