Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upf_to_json python package #9862

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Conversation

simonpintarelli
Copy link
Contributor

Checklist

  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/upf_to_json) and found some lint.

Here's what I've got...

For recipes/upf_to_json:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/upf_to_json) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/upf_to_json:

  • license_file entry is missing, but is expected.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/upf_to_json) and found it was in an excellent condition.

@simonpintarelli simonpintarelli force-pushed the upf_to_json branch 7 times, most recently from d4c2559 to 837b4a8 Compare October 19, 2019 20:33
@simonpintarelli
Copy link
Contributor Author

@marcelotrevisani I'd be happy if you could consider to merge this PR. Thanks!


about:
home: https://github.com/simonpintarelli/upf_to_json
license: BSD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of BSD is this? eg BSD-3-Clause?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is BSD-3-Clause, I've corrected it.

@scopatz scopatz merged commit 15ef31a into conda-forge:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants