Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure numpy1.21python3.10.____cpython pipeline fails to build cython package with "error: 'PyThreadState' {aka 'struct _ts'} has no member named" #35

Closed
wants to merge 7 commits into from

Conversation

JohannesBuchner
Copy link
Contributor

@JohannesBuchner JohannesBuchner commented Apr 7, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@JohannesBuchner
Copy link
Contributor Author

@conda-forge-admin, please rerender

@JohannesBuchner JohannesBuchner changed the title bump version Azure numpy1.21python3.10.____cpython pipeline fails to build cython package with "error: 'PyThreadState' {aka 'struct _ts'} has no member named" Apr 7, 2022
@JohannesBuchner
Copy link
Contributor Author

@conda-forge/core

It does not seem to be possible to build cython packages in numpy1.21 + python3.10?

The error is:

error: 'PyThreadState' {aka 'struct _ts'} has no member named 'use_tracing'

related issues, but not on azure: pik-copan/pyunicorn#154 mahyarnajibi/SNIPER#189 mcfletch/pyopengl#11

I tried to mitigate by adding cython as a build dependency, and it is conda installed now. This did not change the error.

related stackoverflow questions:

@JohannesBuchner
Copy link
Contributor Author

@chrisburr Thanks for having a look. Maybe "pip install --global-option build --global-option --force ." from https://stackoverflow.com/a/65696724/885650 could be worth trying. I won't do anything here until you are done.

@chrisburr
Copy link
Member

The issue was that cython wasn't been used to regenerate the files and the sdist on PyPI was generated with too old a version of cython for Python 3.10. I could tell as this was missing from the logs:

  Compiling ultranest/mlfriends.pyx because it changed.
  Compiling ultranest/stepfuncs.pyx because it changed.
  [1/2] Cythonizing ultranest/mlfriends.pyx
  [2/2] Cythonizing ultranest/stepfuncs.pyx

It looks like it's working now so back over to you! 😄

(Feel free to switch to --global-option build --global-option --force if you prefer, I don't have a strong opinion either way)

@JohannesBuchner
Copy link
Contributor Author

Thanks a lot @chrisburr!

@JohannesBuchner
Copy link
Contributor Author

The problem is that I included .c files in the pypi release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants