Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd zlib to 1.3 #76

Merged
merged 7 commits into from
Jan 9, 2024
Merged

upd zlib to 1.3 #76

merged 7 commits into from
Jan 9, 2024

Conversation

ekomarova
Copy link
Contributor

@ekomarova ekomarova commented Oct 23, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR is designed to update zlib to 1.3 and address https://nvd.nist.gov/vuln/detail/CVE-2023-45853

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ekomarova
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ekomarova
Copy link
Contributor Author

@groutr @msarahan @isuruf @ocefpaf Please review

@ocefpaf
Copy link
Member

ocefpaf commented Oct 23, 2023

LGTM, the appveyor hook is there due to an error. B/c zlib is fundamental do many packages I'd love for @isuruf's input before we merge this one.

@Neustradamus
Copy link

@ekomarova: Do not forget the CVE patch too before a 1.3.1 build.

Linked to:

@Neustradamus Neustradamus mentioned this pull request Oct 23, 2023
5 tasks
@ekomarova
Copy link
Contributor Author

@ekomarova: Do not forget the CVE patch too before a 1.3.1 build.

Linked to:

Oh, it looks like I missed that this will only be fixed in 1.3.1

@ekomarova
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ekomarova
Copy link
Contributor Author

@groutr @msarahan @isuruf @ocefpaf Please review

sha256: b3a24de97a8fdbc835b9833169501030b8977031bcb54b3b3ac13740f846ab30
sha256: ff0ba4c292013dbc27530b3a81e1f9a813cd39de01ca5e0f8bf355702efa593e
patches:
- CVE-2023-45853.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with the PR (madler/zlib#843) and some text reminding us to drop it in the new release?

@ocefpaf ocefpaf added the automerge Merge the PR when CI passes label Jan 9, 2024
@github-actions github-actions bot merged commit 6e17802 into conda-forge:main Jan 9, 2024
9 checks passed
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants