-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize whitespace in dependencies widget #262
Conversation
I think because the rest of the UI has so much whitespace, I'd like to add just a little bit back in between the list entries. Maybe just 2 pxs? Also, the issue also includes the sizing of the widget box. Id like it to be twice as tall as it is right now. |
That works for me but I noticed that we were having a different result between the two themes, You can switch the color theme by editing your
I guess that's not the consequence of your PR but the consequence of another PR. Can you check if you find a PR related to this, and fix it so we have a coherent design on both themes please ? result with
|
Yes @pierrotsmnrd! I also noticed that the themes don't match. I'll create a new issue for this. I also found that having a box is a little bit weird because I thought they were checkboxes at first. Maybe we need to have a discussion on how we want this to look in both themes. |
I agree they look like checkboxes, they should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for merge. The slight difference between both themes as described above will be handled in a different issue
New issue at: #266 Thanks for the review! |
Fixes #242
This PR,
Screenshots
Before
After
Questions
flex
for it to be properly rendered. In case we want to go that way, I would suggest to do it in a follow up PR.