Add NotFound component and 404 redirect #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
force-pushed
the
redirect-not-found
branch
from
c4f22be
to
cc40c69
Compare
|
I made this a draft PR for now until we have server-side support for the On the other hand, if we don't mind showing the server-controlled 404 page... 
|
2 tasks
|
Since there is now a companion server pull request, I will take this out of draft. |
| height: "100%" | ||
| }} | ||
| > | ||
| <Typography variant="h1" sx={{ fontSize: "18px", color: "#333" }}> |
There was a problem hiding this comment.
Not sure if now is the time to think about this, but do we have some global theme somewhere where these colors are stored? In the future we may want to support theming (so that we can integrate nicely with JupyterLab, among other reasons).
| // useHref takes into account React Router basename option. So if basename is | ||
| // set to "/conda-store", the hook will return "/conda-store/not-found" | ||
| const url = useHref("/not-found"); | ||
| window.location.replace(url); |
There was a problem hiding this comment.
How does this work when using MemoryRouter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to conda-incubator/conda-store#899
Description
The basic idea of this pull request is that if the app loads and the user is at some unknown route such as
/conda-store/foo/bar, the app will forcefully redirect them to/conda-store/not-found. This redirect should hit the server, which should return this React app along with a 404 HTTP status code. The app will in turn execute at this URL and render a "not found" page.This pull request:
history.pushState()but an actual refresh of the browser page usingwindow.location.replace(){urlBasename}/not-foundroute matches.Pull request checklist