Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement variable parsing for environments #424

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Implement variable parsing for environments #424

merged 4 commits into from
Jan 31, 2023

Conversation

anirrudh
Copy link
Contributor

@anirrudh anirrudh commented Jan 24, 2023 •
edited
Loading

This solves issue #413 by updating the schema and the according unpacking of those variables.

cc: @dharhas @costrouc

costrouc
costrouc approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @anirrudh!

@costrouc costrouc merged commit 8efa83f into main Jan 31, 2023
@costrouc costrouc deleted the feature/add-variable-parsing-413 branch January 31, 2023 02:24
@ranchodeluxe ranchodeluxe mentioned this pull request Feb 5, 2023
Closed
@nkaretnikov nkaretnikov mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirrudh @costrouc