Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding build canceling (only works with compatible celery brokers redis and rabbitmq) #531

Merged
merged 31 commits into from
Dec 18, 2023
Merged

Adding build canceling (only works with compatible celery brokers redis and rabbitmq) #531

merged 31 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. Adding build canceling (only works with compatible celery brokers red… 

    …is/rabbitmq)

Closes #306
    @costrouc @nkaretnikov
    costrouc authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a00ab59 View commit details
    Browse the repository at this point in the history

  2. Adding test within route to check for cancelation support

    @costrouc @nkaretnikov
    costrouc authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e074f15 View commit details
    Browse the repository at this point in the history

  3. Black formatting

    @costrouc @nkaretnikov
    costrouc authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a709085 View commit details
    Browse the repository at this point in the history

  4. Missing enum in test

    @costrouc @nkaretnikov
    costrouc authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7a26238 View commit details
    Browse the repository at this point in the history

  5. Adding a cleanup task which allows for marking the canceled bulids as… 

    … failed
    @costrouc @nkaretnikov
    costrouc authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fb38b52 View commit details
    Browse the repository at this point in the history

  6. Black formatting

    @costrouc @nkaretnikov
    costrouc authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5b537a2 View commit details
    Browse the repository at this point in the history

  7. first pass at adding tests for build cancellations

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fa8d70a View commit details
    Browse the repository at this point in the history

  8. use proper schema object

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8224827 View commit details
    Browse the repository at this point in the history

  9. ensure build status is marked as failed

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1de3b48 View commit details
    Browse the repository at this point in the history

  10. typo fix

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    740eddf View commit details
    Browse the repository at this point in the history

  11. add time delays to ensure statuses are updated to most recent state

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e7b187c View commit details
    Browse the repository at this point in the history

  12. increase timeout

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f522779 View commit details
    Browse the repository at this point in the history

  13. add while loop to periodically ping the API and see if building

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ef5c7d4 View commit details
    Browse the repository at this point in the history

  14. modify tests to catch edge cases

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    36912a0 View commit details
    Browse the repository at this point in the history

  15. playing with time, again

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    14a5568 View commit details
    Browse the repository at this point in the history

  16. set timeout to 3 mins

    @anirrudh @nkaretnikov
    anirrudh authored and nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7067180 View commit details
    Browse the repository at this point in the history

  17. Use conda_store.get_db instead of dependencies.get_db

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a079ff8 View commit details
    Browse the repository at this point in the history

  18. Reduce the delay to fix a flaky test

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9f21660 View commit details
    Browse the repository at this point in the history

  19. Reduce another delay that's likely too long

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    60cf561 View commit details
    Browse the repository at this point in the history

  20. Check the full message text

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    78bce82 View commit details
    Browse the repository at this point in the history

  21. Handle exception when getting a build 

    ```
requests.exceptions.ConnectionError: ('Connection aborted.',
  RemoteDisconnected('Remote end closed connection without response'))
```
    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    52699b3 View commit details
    Browse the repository at this point in the history

  22. Add test_api_cancel_build_unauth

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a29efb0 View commit details
    Browse the repository at this point in the history

  23. Add an assert

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    892c056 View commit details
    Browse the repository at this point in the history

  24. Formatting fixes

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b1d7191 View commit details
    Browse the repository at this point in the history

  25. Add raise_for_status

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    198eb42 View commit details
    Browse the repository at this point in the history

  26. Fix the task id

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2cb8c7b View commit details
    Browse the repository at this point in the history

  27. Add a comment

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f37c92f View commit details
    Browse the repository at this point in the history

  28. Fix a flaky test

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    68dd0f1 View commit details
    Browse the repository at this point in the history

  29. Split a long string

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    347a9aa View commit details
    Browse the repository at this point in the history

  30. Make the test less flaky

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    405036b View commit details
    Browse the repository at this point in the history

  31. Add a comment about countdown=5

    @nkaretnikov
    nkaretnikov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    97b9940 View commit details
    Browse the repository at this point in the history