Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate constructor artifacts #714

Merged
merged 37 commits into from
Jan 28, 2024
Merged

Generate constructor artifacts #714

merged 37 commits into from
Jan 28, 2024

Conversation

nkaretnikov
Copy link
Contributor

@nkaretnikov nkaretnikov commented Dec 21, 2023 •
edited
Loading

Fixes #657.

Description

This pull request:

  • adds action_generate_constructor_installer, which generates sh and exe installers via constructor
  • exposes this in the API via /api/v1/build/{build_id}/installer/
  • adds tests
  • updates the docs.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 30f2f23
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65b68ea0ff796b000877d3e6

@nkaretnikov nkaretnikov added this to the challenges 🛠 milestone Dec 21, 2023
@nkaretnikov

This comment was marked as outdated.

Sign in to view
@nkaretnikov

This comment was marked as outdated.

Sign in to view
nkaretnikov
nkaretnikov commented Dec 25, 2023
View reviewed changes
conda-store-server/conda_store_server/action/generate_constructor_installer.py
if sys.platform == "win32":
post_install = """\
call "%PREFIX%\Scripts\activate.bat"
"""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be:

call "%PREFIX%\Scripts\\activate.bat"

Since \a is a special character.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, raw string:

post_install = r"""\
call "%PREFIX%\Scripts\activate.bat"
"""

@nkaretnikov nkaretnikov marked this pull request as ready for review December 25, 2023 10:37
@nkaretnikov nkaretnikov merged commit c9ff637 into conda-incubator:main Jan 28, 2024
18 checks passed
@nkaretnikov nkaretnikov deleted the constructor-artifacts-657 branch January 28, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp approved these changes

Assignees
No one assigned
Labels
area: dependencies 📦 Issues related to conda-store dependencies deliverable 📦 Project or grant deliverable project: challenges type: enhancement 💅🏼
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
challenges: Round 1 🛠
Development

Successfully merging this pull request may close these issues.

[ENH] - Teach conda-store how to generate constructor artifacts
2 participants
@nkaretnikov @jaimergp