Add status CANCELED
#747
Merged
Add status CANCELED
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
nkaretnikov
added
type: enhancement 💅🏼
area: UI/UX design ✨
area: api
status: in progress 🏗
status: needs changes 🧱
project: JATIC
nkaretnikov
force-pushed
the
status-canceled-547
branch
from
59cb551
to
e778e13
Compare
nkaretnikov
commented
Feb 25, 2024
| conda_store = self.worker.conda_store | ||
| with conda_store.session_factory() as db: | ||
| build_cleanup(db, conda_store, build_ids, reason) | ||
| build_cleanup(db, conda_store, build_ids, reason, is_canceled) |
There was a problem hiding this comment.
conda-store-ui will need to be updated after this lands to support this better. Currently, it shows undefined for these builds because it doesn't know about this new status:
nkaretnikov
commented
Feb 26, 2024
|
|
||
|
|
||
| def downgrade(): | ||
| op.execute("DELETE FROM build WHERE status = 'CANCELED'") |
There was a problem hiding this comment.
This migration does the same thing as the one we have for the installer:
https://github.com/conda-incubator/conda-store/blob/main/conda-store-server/conda_store_server/alembic/versions/57cd11b949d5_add_installer.py
The reason the downgrade part is different is because it's a no-op here with canceled, since the field size is the same.
dcmcand
approved these changes
Feb 27, 2024
nkaretnikov
force-pushed
the
status-canceled-547
branch
from
bc576d4
to
61be69f
Compare
nkaretnikov
added
status: merge ready 🚀
and removed
status: in progress 🏗
needs: review 👀
labels
|
@gabalafou I have not verified if this is working as expected, could you check please? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547.
Description
This pull request: adds status
CANCELED, which is displayed in the web UI when the user cancels a build.Pull request checklist
Additional information
How to test