Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set logout url properly when using the integrated ui #884

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Sep 19, 2024

Properly sets the logout url when using the integrated ui.

Fixes nebari-dev/nebari#2717

Description

Currently, using the c.CondaStoreServer.enable_ui = True configuration option uses conda-store-ui with the following config:

var condaStoreConfig = {
             NODE_DEBUG: null,
             REACT_APP_CONTEXT: "single-page-app", // not a true setting
             REACT_APP_AUTH_METHOD: "cookie",
             REACT_APP_AUTH_TOKEN: "",
             REACT_APP_STYLE_TYPE: "green-accent",
             REACT_APP_SHOW_LOGIN_ICON: "true",
             REACT_APP_API_URL: "{{ url_for('get_conda_store_ui') }}",
             REACT_APP_LOGIN_PAGE_URL: "{{ url_for('get_login_method') }}?next=",
         };

The fact that the logout url is not set results in logout not working. We can see in https://nebari.quansight.dev/conda-store/ that the logout route is set to the default value.

Screenshot from 2024-09-17 17-48-41

This pull request:

  • Adds the REACT_APP_LOGOUT_PAGE_URL configuration option to the invocation of conda-store-ui.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

Start conda-store-server with the c.CondaStoreServer.enable_ui = True.
Load the ui and login
Logout

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 63d9dd7
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66ec1c4ad8107800086d7579

@trallard trallard merged commit a3e626a into main Sep 19, 2024
28 checks passed
@trallard trallard deleted the dcmcand-add-logout-url-to-ui branch September 19, 2024 13:49
@kcpevey
Copy link
Contributor

kcpevey commented Sep 19, 2024

Just to make it clear since we are mid-release... will this be included in the 2024.9.1 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Conda-store log out does not work
3 participants