Merge pull request #94 from jaimergp/invalid-env-syntax-errors

Try to catch EnvironmentSectionNotValid

.github/workflows/example-8.yml

@@ -0,0 +1,39 @@
+name: "Example 8: this should fail"
+
+on:
+  pull_request:
+    branches:
+      - "*"
+  push:
+    branches:
+      - "master"
+
+jobs:
+  example-1:
+    name: Ex1 (${{ matrix.python-version }}, ${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest", "macos-latest", "windows-latest"]
+        python-version: ["3.7", "2.7"]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ./
+        id: setup-miniconda
+        with:
+          auto-update-conda: true
+          python-version: ${{ matrix.python-version }}
+          environment-file: etc/example-faulty-environment.yml
+      - name: Check previous step failed
+        shell: bash
+        run: ${{ steps.setup-miniconda.conclusion == "failure" }}
+      - name: Conda info
+        shell: bash -l {0}
+        run: conda info
+      - name: Conda list
+        shell: pwsh
+        run: conda list
+      - name: Environment
+        shell: bash -l {0}
+        run: printenv | sort

etc/example-faulty-environment.yml

@@ -0,0 +1,4 @@
+name: anaconda-client-env
+requirements:
+  - black
+  - anaconda-client

src/setup.ts

@@ -76,6 +76,14 @@ const IGNORED_WARNINGS = [
   `Key 'use_only_tar_bz2' is not a known primitive parameter.`,
 ];
 
+/**
+ * warnings that should be errors
+ */
+const FORCED_ERRORS = [
+  // conda env create will ignore invalid sections and move on
+  `EnvironmentSectionNotValid`,
+];
+
 /**
  * avoid spurious conda warnings before we have a chance to update them
  */
@@ -93,6 +101,18 @@ async function execute(command: string): Promise<Result> {
   let options: exec.ExecOptions = {
     errStream: new stream.Writable(),
     listeners: {
+      stdout: (data: Buffer) => {
+        const stringData = data.toString();
+        for (const forced_error of FORCED_ERRORS) {
+          if (stringData.includes(forced_error)) {
+            return {
+              ok: false,
+              error: new Error(`"${command}" failed with "${forced_error}"`),
+            };
+          }
+        }
+        return data;
+      },
       stderr: (data: Buffer) => {
         const stringData = data.toString();
         for (const ignore of IGNORED_WARNINGS) {