-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (Mini/Mamba)forge #133
Conversation
Hooray 💚 ! |
Thanks for working on this @bollwyvl, this is awesome :) |
action.yml
Outdated
@@ -180,13 +200,26 @@ inputs: | |||
removed from the runner. Default is "true".' | |||
required: false | |||
default: "true" | |||
mamba-in-installer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be checked programmatically? Once installed one can check for mamba
or mamba.bat
in $PREFIX/condabin
and determine it without user intervention, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm... it's probably worth a look...
Absolutely, I think we are big enough that we can have dedicated docs :) will set something with githubpages and myst :) |
…s no-op, but needs bash wrapper
Ok, so ab60b01 is back to 🟢 and 4651cc0 is mostly cosmetic... thanks @jaimergp for pushing to remove the manual thing: doing the detection uncovered a number of future bugs (e.g. adding that bash wrapper on windows).
Let's definitely squash merge this one :P |
Nice!
Hopefully this is addressed at the mamba level at some point (them providing a shell command like conda does) |
Nice!
adding that bash wrapper on windows
Hopefully this is addressed at the mamba level at some point (them
providing a shell command like conda does)
Indeed. Guess we should issue? I'm a little mamba-ed out right now.
God help zsh/fish windows users... But I could see xonsh, frankly...
P-strings are awesome for windows "specialness".
|
Another awesome piece of work @bollwyvl :) 🥳 Thanks! |
Related
Code Changes
download-miniforge.ts
Can we use use conda create?
conda.ts
use-mamba
andis specified, will try to usemamba-in-installer
mamba
earlier in the process, but also catches things likeconda init
which aren't supported by themamba
CLI yetinstaller/index.ts
mamba
base-tools/index.ts
upgrade-mamba.ts
User-facing changes
miniforge-variant
,miniforge-version
, to specify a Miniforge productandmamba-in-installer
use-mamba
to fine-tune use of MambaforgeBackwards-incompatible changes
N/A
Follow-on
micromamba
(Micromamba based setup? #75), but:mamba
CLI doesn't yet appear to supportinit
for shell integration...micromamba
into the bundled minicondabin
orScripts
orcondabin
or something?