Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy channels before reversing #161

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Mar 29, 2021

  • fixes Channel priority changed in 2.1.0 release #160
  • use .slice to copy channels before reversing
  • updates package-lock.json after installing from fresh environment
  • add "typical" channel line-up to example environment
  • add test of environment-patched.yml? Hoist to output?

@bollwyvl
Copy link
Contributor Author

By inspection, this is fixing the issue:
https://github.com/conda-incubator/setup-miniconda/pull/161/checks?check_run_id=2222447371#step:3:257

the order is as set in the original yaml. I don't know how to simply retrieve the logs from within the action (if that's even possible), but otherwise this is ready for review.

@bollwyvl bollwyvl changed the title Copy channels from YAML before reversing Copy channels before reversing Mar 29, 2021
@bollwyvl
Copy link
Contributor Author

I guess we could hoist the "effective used environment" to an action output...

@jaimergp
Copy link
Member

So what was the issue? .reverse() acting in place instead of returning a reversed "view" and that can leave the list of channel in the wrong state for the next operation?

@bollwyvl
Copy link
Contributor Author

acting in place instead of returning a reversed "view"

right, gory details on #160

@jaimergp
Copy link
Member

jaimergp commented Mar 29, 2021

Huh, that's surprising indeed, at least coming from the Python world. If that's the case and this fixes the misbehavior, this LGTM.

How would you like to check for the right behavior? Diffing conda lists?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Mar 29, 2021 via email

@goanpeca
Copy link
Member

Looks good @bollwyvl

Should I make a 2.1.1 release?

@goanpeca goanpeca merged commit a71ed3d into conda-incubator:develop Mar 29, 2021
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Mar 29, 2021 via email

@bollwyvl bollwyvl mentioned this pull request Mar 31, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants