-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add conda channels option #17
Conversation
@dcdenu4 could you test this PR ? You can use this branch as |
@goanpeca I tested it on my simple use case and it appears to work properly and pull from the added channels. It looks like for Thanks for this! |
That order is weird indeed I think I have an issue there so that is not right. I will need to look i to it then |
Ok I knew that could be an issue https://zellwk.com/blog/async-await-in-loops/ I need to change to a normal for otherwise the order is not guaranteed. And I learned something new about Js :-p |
@dcdenu4 fixed the issue now. It should be in the right order now! Could you please check before the merge? (at lest on two consecutive builds?) |
@goanpeca Just ran two tests and they both use the first channel in my list, |
Thanks for testing @dcdenu4 making a release soon ;-) |
Related to #4