Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add conda channels option #17

Merged
merged 1 commit into from
Mar 19, 2020
Merged

PR: Add conda channels option #17

merged 1 commit into from
Mar 19, 2020

Conversation

goanpeca
Copy link
Member

Related to #4

@goanpeca goanpeca added this to the v1.1.0 milestone Mar 19, 2020
@goanpeca goanpeca self-assigned this Mar 19, 2020
@goanpeca goanpeca changed the base branch from master to 1.x March 19, 2020 03:05
@goanpeca goanpeca changed the base branch from 1.x to test-examples March 19, 2020 03:05
@goanpeca goanpeca changed the base branch from test-examples to 1.x March 19, 2020 03:05
@goanpeca
Copy link
Member Author

@dcdenu4 could you test this PR ?

You can use this branch as goanpeca/setup-miniconda@enh/channels

@dcdenu4
Copy link

dcdenu4 commented Mar 19, 2020

@goanpeca I tested it on my simple use case and it appears to work properly and pull from the added channels. It looks like for channels: conda-forge, anaconda , the priority order is anaconda, then conda-forge. It's a little counter intuitive to me, as I would think the first thing I list has the greatest priority, but if it's documented well then it doesn't really matter.

Thanks for this!

@goanpeca
Copy link
Member Author

That order is weird indeed I think I have an issue there so that is not right.

I will need to look i to it then

@goanpeca
Copy link
Member Author

Ok I knew that could be an issue https://zellwk.com/blog/async-await-in-loops/

I need to change to a normal for otherwise the order is not guaranteed.

And I learned something new about Js :-p

@goanpeca
Copy link
Member Author

goanpeca commented Mar 19, 2020

@dcdenu4 fixed the issue now. It should be in the right order now! Could you please check before the merge? (at lest on two consecutive builds?)

@dcdenu4
Copy link

dcdenu4 commented Mar 19, 2020

@goanpeca Just ran two tests and they both use the first channel in my list, conda-forge in my case. So this is expected and different than prior when it was using anacaonda, my 2nd specified channel. Looks good!

@goanpeca
Copy link
Member Author

Thanks for testing @dcdenu4 making a release soon ;-)

@goanpeca goanpeca merged commit 1bff5f2 into 1.x Mar 19, 2020
@goanpeca goanpeca deleted the enh/channels branch March 24, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants