Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify team conda-incubator/setup-miniconda as codeowners #313

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

dbast
Copy link
Member

@dbast dbast commented Nov 23, 2023

This auto-assigns the team as PR reviewers, which has 3 advantages:

  • contributors can see from whom potentially to expect feedback in PRs.
  • the maintainers aka team members get a better signal to filter for PRs to be reviewed by them.
  • allows to enable branch protections (in case we want that in the future) where at least one approval by a codeowner is required for PRs to be merged.

This auto-assigns the team as PR reviewers, which has 3 advantages:
* contributors can see from whom potentially to expect feedback in PRs.
* the maintainers aka team members get a better signal to filter for PRs
  to be reviewed by them.
* allows to enable branch protections (in case we want that in the future)
  where at least one approval by a codeowner is required for PRs to be
  merged.
@dbast dbast requested a review from a team November 23, 2023 14:36
@goanpeca goanpeca merged commit 538b6c1 into main Nov 23, 2023
49 checks passed
@goanpeca goanpeca deleted the codeowners branch November 23, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants