-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to miniconda3 latest when no bundled version + empty with params #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arams Fixes the no "with"-parameters case on osx-arm64 while there is no bundled version available.
dbast
force-pushed
the
fix-empty-with
branch
from
February 27, 2024 11:08
fc12c9b
to
82cbdc0
Compare
dbast
changed the title
Fix: No "with"-parameters on osx-arm64
Fall back to miniconda3 latest when no bundled version + empty with params
Feb 27, 2024
jezdez
reviewed
Feb 27, 2024
dbast
commented
Feb 27, 2024
dbast
force-pushed
the
fix-empty-with
branch
from
February 27, 2024 13:40
2bc9291
to
9c8c6e7
Compare
jezdez
approved these changes
Feb 27, 2024
dbast
commented
Feb 27, 2024
goanpeca
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @dbast, thanks for working on this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fall back to miniconda3 latest when no bundled version + empty with params. Fixes the no "with"-parameters case on osx-arm64 while there is no bundled version available as found here https://github.com/conda/conda/actions/runs/8057143952/job/22019628418