-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation-dir
to customize where the installers are installed to
#342
Conversation
cc @finnagin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment about the name chosen for now. Implementation looks ok. We should add an example test to make sure this works as intended.
action.yml
Outdated
@@ -29,6 +29,11 @@ inputs: | |||
installers" | |||
required: false | |||
default: "" | |||
install-dir: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to using installation-directory
here instead. The rest of the options in this project seem to be using no abbreviations (e.g. we fully spell environment
instead of env
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installation-dir
to customize where the installers are installed to
Thanks! |
This is useful for self-hosted runners where we can change the installation directory to the workspace directory to allow automatic cleaning up of the miniforge/miniconda environments.