-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add architecture option to installation candidates #52
Conversation
The user can select an architecture supported by their Actions runner as an option in the with block. Closes conda-incubator#10
This appears not to have done anything so far, see: https://github.com/Cantera/conda-recipes/pull/22/checks?check_run_id=823649924#step:3:15 which is still using the pre-installed Miniconda I'm not sure if I need to add the built |
Hi @bryanwweber thanks for taking look. Now, we need to force a miniconda install from scratch for this to work, since it is not possible to "change" the architecture and user the bundled one. So if |
Thanks for the feedback! I had interpreted this line: as: "if minicondaVersion is set OR architecture isn't equal to x64", in which case, when I set Looking at it now, I see that |
Make sure that architectures other than x86_64 can be downloaded.
@bryanwweber, @goanpeca, I really like the setup-miniconda action and I could use the architecture option for several projects! Great work! What ist the status on this PR? BTW, I played around with this the https://github.com/DLR-SC/tigl-conda/runs/965599369?check_suite_focus=true#step:3:66 Do you have an idea what this is about? Is this a permission issue? |
@joergbrech It seems as though Anaconda have dropped support for x86 Linux, the installer is from January of last year (2019) |
Hi @bryanwweber, sorry I have swamped with work, and I still have to review this! Thanks @joergbrech, indeed I do not think the Linux issue is solvable (we should probably disallow it @bryanwweber) |
Ah, I did not know that. Thanks for the info. I am looking forward to this being merged! Thanks again for the great work! |
Thanks @goanpeca I'll try to add another check for that condition. No problem about the delay, we ended up just dropping Win32 support for our package rather than trying to build the conda package, so I ended up not needing this feature 😄 |
Anaconda appear to have dropped support for 32-bit Linux distributions sometime in 2019.
@goanpeca I've pushed a change that errors out when 32-bit Linux is used |
Awesome! I will merge an iterate! Thanks! |
The user can select an architecture supported by their Actions runner as
an option in the with block.
Closes #10