-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CEPs to 0000 based #95
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
* conda/conda-core | ||
* conda/steering-council | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# disable autofixing PRs, commenting "pre-commit.ci autofix" on a pull request triggers a autofix | ||
ci: | ||
autofix_prs: false | ||
# generally speaking we ignore all vendored code as well as tests data | ||
exclude: | | ||
(?x)^( | ||
tests/data/.* | | ||
conda_libmamba_solver/mamba_utils\.py | ||
)$ | ||
repos: | ||
# generic verification and formatting | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v5.0.0 | ||
hooks: | ||
# standard end of line/end of file cleanup | ||
- id: mixed-line-ending | ||
- id: end-of-file-fixer | ||
- id: trailing-whitespace | ||
- id: check-merge-conflict | ||
- repo: meta | ||
# see https://pre-commit.com/#meta-hooks | ||
hooks: | ||
- id: check-hooks-apply | ||
- id: check-useless-excludes |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd love to have the table generated automatically. A new PR likely or maybe a custom pre-commit extension? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, it would be useful in |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
<tr><td> Title </td><td> Serving run_exports metadata in conda channels </td> | ||
<tr><td> Status </td><td> Accepted </td></tr> | ||
<tr><td> Author(s) </td> | ||
<td> | ||
<td> | ||
Jaime Rodríguez-Guerra <[email protected]> | ||
</td></tr> | ||
<tr><td> Created </td><td> May 4, 2023</td></tr> | ||
|
@@ -27,11 +27,11 @@ Since `conda-index` already processes the package metadata to generate `repodata | |
|
||
## Precedence and role in the pinning resolution process | ||
|
||
This file is not meant to replace the `run_exports` metadata already present in the package archives. It merely presents that information in a more convenient way. | ||
This file is not meant to replace the `run_exports` metadata already present in the package archives. It merely presents that information in a more convenient way. | ||
`conda-build`-like clients are free to use either the `run_exports` metadata in the archives or the one in `run_exports.json`, since they MUST be equivalent. | ||
Special keys like `pin_run_as_build` MUST keep their behavior, since `run_exports.json` does not add a new level of precedence in the pinning resolution process. Again, it's an equivalent source for information already present in the archives. | ||
|
||
This means that `run_exports.json` MUST NOT be patched (like it is done with `repodata.json`). It MUST always reflect the metadata present in the archives. | ||
This means that `run_exports.json` MUST NOT be patched (like it is done with `repodata.json`). It MUST always reflect the metadata present in the archives. | ||
|
||
> Note this only applies to the served `run_exports.json` file. It does not try to regulate what | ||
> `conda-build`-like tools can do at environment creation time. They might need to apply | ||
|
@@ -57,7 +57,7 @@ Each `run_exports` metadata `dict` can contain the following fields; each field | |
- `noarch` | ||
|
||
```json | ||
{ | ||
{ | ||
"info": { | ||
"platform": "string", | ||
"arch": "string", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is invalid; the team exists.