Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stress that .lock extension is necessary #280

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

klieret
Copy link
Contributor

@klieret klieret commented Nov 14, 2022

It took me a while to realize that conda/mamba refuses to deal with conda-lock files if they have a yaml ending (throwing a very ugly decoding error).

This PR tries to make this more clear in the readme (though it is more of an issue with conda/mamba, I guess).

(Also see mamba-org/provision-with-micromamba#106)

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit fe0e0a3
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6372cce04046d00009acc5c5
😎 Deploy Preview https://deploy-preview-280--conda-lock.netlify.app/cli/gen
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! I think such small documentation changes make a big difference.

@mariusvniekerk mariusvniekerk merged commit 901924d into conda:main Nov 15, 2022
@mariusvniekerk
Copy link
Collaborator

We can also potentially just attempt to parse every file initially with the conda lock format and if that works treat it as such. That minimizes surpise factors

@klieret klieret deleted the patch-1 branch November 15, 2022 16:56
@klieret
Copy link
Contributor Author

klieret commented Nov 15, 2022

My major dissatisfaction was that the error message was very unhelpful. So just catching & reraising the error with a bit of added bit of information ("Please note that file extensions matter: For example, if you try to read a .... file... use the conda-lock.yml ending") etc. would already add a lot, without changing any logic.

@maresb
Copy link
Contributor

maresb commented Nov 15, 2022

@klieret, thanks again for the contribution. We're very happy to accept PRs which improve the error handling. For example, I just added #282 this morning.

@klieret
Copy link
Contributor Author

klieret commented Nov 15, 2022

Thanks @maresb! I plan follow up with a PR (though I'm a bit short on time atm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants