Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Vendored Poetry Store Config, Cache, and Data Folders in "pypoetry-conda-lock" #342

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

srilman
Copy link
Contributor

@srilman srilman commented Feb 10, 2023

Description

We determined that the problems we noticed in #315 was caused when Poetry is installed on a user's machine and it's cache conflicts with the vendored poetry's cache. By modifying the locations inside of vendored poetry, we can ensure that it

  • Stores it cache, config files, and data folder in a different folder from poetry. Poetry stores them in a folder called "pypoetry" and we will in "pypoetry-conda-lock". Note that the location of the folder is OS specific. More details can be found here: https://python-poetry.org/docs/configuration/#default-directories
  • Ensure that vendored poetry will not use any config options a user sets for regular poetry

Note that as @maresb suggested in #315 (comment), I added a option to vendoring in pyproject.toml to replace any instances of "pypoetry", but manually modified the affected file myself since re-vendoring Poetry is not possible right now.

@srilman srilman requested a review from a team as a code owner February 10, 2023 01:03
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 36a2c95
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63e63448bf5f9c0008f8cc30
😎 Deploy Preview https://deploy-preview-342--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@srilman srilman changed the title Modify Vendored Poetry to Point Config, Cache, and Data Path from "pypoetry" to "pypoetry-conda-lock" Have Vendored Poetry Store Config, Cache, and Data Folders in "pypoetry-conda-lock" Feb 10, 2023
@srilman srilman force-pushed the poetry-vendored-directory branch 3 times, most recently from 2e3c159 to 272e773 Compare February 10, 2023 05:21
@maresb
Copy link
Contributor

maresb commented Feb 10, 2023

In preparation to merge I removed the debug commit and rebased on main.

@maresb
Copy link
Contributor

maresb commented Feb 10, 2023

I will be entirely AFK a while, but I would have liked to merge as soon as this turns green. Perhaps we should enable GH automerge in this repo.

@srilman
Copy link
Contributor Author

srilman commented Feb 10, 2023

Why not allow the PR creator to merge their PR when ready? We can set GitHub up to only allow Merges (not Squash or Rebase) and to only enable it once all checks are passing.

@maresb maresb merged commit 0eefb1f into conda:main Feb 11, 2023
@maresb
Copy link
Contributor

maresb commented Feb 11, 2023

Thanks a lot @srilman for all your help!!!

Why not allow the PR creator to merge their PR when ready? We can set GitHub up to only allow Merges (not Squash or Rebase) and to only enable it once all checks are passing.

Do you know the specific settings we'd need to change to set this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants