-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for git to lockfile #394
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Awesome! Looks like a great start. Thanks so much! I hope to take a closer look soon. |
Thanks, ended up being less code than I expected. I wish their was a more robust package for parsing the vcs + url + hash, I thought that pkg_resource being deprecated (https://setuptools.pypa.io/en/latest/pkg_resources.html) the replacement (https://packaging.pypa.io/en/stable/requirements.html#requirements) would have some better utilities for this... |
Yes, we should migrate that. Feel free to be bold with your PR. ;) |
Just leaving this here, here is how poetry core deals with the vcs problem (similar) |
@maresb in the process of being bold, I think we can re-use some upstream poetry handling around Requirements/link parsing, although if you want to in the long run remove the vendored dependencies in favor of a custom solver that might make de-integration slightly more complicated. Would it be possible to get a poetry bump merged soon #310? |
Leaving the door to Poetry de-integration is really important to me. That said, I would really like to bump the vendored Poetry. Also, as opposed to importing directly from Doing the vendoring requires me finding a good chunk of uninterrupted time where I can see through the whole process. Over the next month or so I have a lot of major drains on my personal time, so I can't really promise anything, but I'll try to get to it soon. |
Yeah 100%, totally understand the time constraints situation. I'm just excited to see this feature in conda-lock and want to do what I can (coding-wise) to make that happen :) Just lmk where I should go from here, for now this fork lets me lock chumpy from git haha. |
Is there motivation to continue this? I think it would be good to support the |
Yes, absolutely. I'm hoping to get around to revendoring Poetry very soon. But please keep in mind that we should leave open the door to removing the vendored Poetry in the future.
Testing, writing tests, code review, resolving the merge conflict, documentation, etc. Thanks a lot for your interest!!! |
Alright, I will continue working on this, as this is a PR from a personal fork I reforked and merged into mine. |
Thanks! I'm still interested in this getting merged, but was waiting on the vendored poetry update |
Already merged in #435 |
Closes #392
This is an incredibly hacky solution for #392, could use some additional direciton on making this more robust (does anyone know a package parser/upstream efforts to get package parsers that resolve git forges?)