Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "fn" in fake_conda_environment for mamba>=1.4.6 compatibility #453

Merged

Conversation

riccardoporreca
Copy link
Contributor

Description

See #452. The initial goal of this (draft) PR is to provide evidence about the fact that including the file name ("fn") in the fake environment packages' JSON file makes mamba>=1.4.6 happy

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit b2791b6
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/64aada92ecfb120008f40bab
😎 Deploy Preview https://deploy-preview-453--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riccardoporreca riccardoporreca force-pushed the feature/452-mamba-fake-env-compatibility branch from e6e7eb1 to 03c8539 Compare July 9, 2023 11:45
@maresb
Copy link
Contributor

maresb commented Jul 9, 2023

This looks good from my side. Before merging let's see if Jonas responds in #452.

@riccardoporreca
Copy link
Contributor Author

@maresb, with the I am still keeping extract_json_object in update_specs_for_arch for consistency with solve_specs_for_arch. Publishing the PR

@riccardoporreca riccardoporreca marked this pull request as ready for review July 9, 2023 15:48
@riccardoporreca riccardoporreca requested a review from a team as a code owner July 9, 2023 15:48
@riccardoporreca riccardoporreca changed the title [Draft] Include "fn" in fake_conda_environment for mamba>=1.4.6 compatibility Include "fn" in fake_conda_environment for mamba>=1.4.6 compatibility Jul 9, 2023
conda_lock/conda_solver.py Outdated Show resolved Hide resolved
conda_lock/conda_solver.py Outdated Show resolved Hide resolved
Apply suggestions from code review

Co-authored-by: Ben Mares <[email protected]>
@maresb maresb mentioned this pull request Jul 9, 2023
@maresb
Copy link
Contributor

maresb commented Jul 9, 2023

I am checking if this allows us to unpin Micromamba in the CI in #454 (before) and #455 (after).

@maresb
Copy link
Contributor

maresb commented Jul 9, 2023

Answer: I can unpin Micromamba independently, presumably thanks to using extract_json_object as in #448.

@maresb maresb merged commit cc0e683 into conda:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants