Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pkg_resources and standardize canonicalization #457

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jul 12, 2023

Description

I'm trying to move things to more standard tooling. pkg_resources was deprecated some time ago. PyPI names should be canonicalized with packaging.utils.canonicalize_name.

TODO: Track down why the deprecation warnings for pkg_resources are being suppressed.

@maresb maresb requested a review from a team as a code owner July 12, 2023 11:17
@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit bbf88be
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/64ae8bc5db97c20008930064
😎 Deploy Preview https://deploy-preview-457--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb
Copy link
Contributor Author

maresb commented Jul 12, 2023

Hey @mjlbach and @muyajil, I'd appreciate any feedback you may have on this.

@maresb maresb merged commit cad88fc into conda:main Jul 21, 2023
@maresb maresb deleted the remove-pkg_resources branch July 21, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants