-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pydantic 2.0 #459
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Are you sure we want to do this already? The Pydantic v2 migration seems like a rough edge. I think this might make it a lot harder for people to install conda-lock in their base environments. |
Maybe we should instead suppress the warnings for a bit? |
The stuff we actually need was introduced in Pydantic 1.10
In light of #462 I think this should be fine. I'm just mildly concerned because I don't understand the effect of removing json_encoders = {frozenset: list} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this deserves its own release
@mariusvniekerk, this is marked as draft, but I think it may be ready to merge? |
Yeah just left it as draft so that we can land whatever we want before landing this breaking dependency |
@mariusvniekerk it looks like I forgot to provide this explanation: The required new functionality exists in Pydantic 1.10, so pinning That should be fine, right? |
Closes #472