Replace suffix_union with less general function
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jacksmith15
commented
Oct 16, 2023
| @@ -51,3 +54,34 @@ def aggregate_lock_specs( | |||
| lock_spec.allow_pypi_requests for lock_spec in lock_specs | |||
| ), | |||
| ) | |||
|
|
|||
|
|
|||
| def unify_package_sources(collections: List[List[Channel]]) -> List[Channel]: | |||
There was a problem hiding this comment.
In #529 I would replace Channel here with:
PackageSource = TypeVar("PackageSource", Channel, PipRepository)
maresb
reviewed
Oct 16, 2023
|
We should also be able to remove |
maresb
reviewed
Oct 16, 2023
Co-authored-by: Ben Mares <[email protected]>
maresb
approved these changes
Oct 16, 2023
|
Thanks so much @jacksmith15, I really appreciate all the effort here! I think this is a huge improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative candidate to #531
This removes the quite complex
suffix_unionfunction with a more specific function for unifying channels when aggregating lock specifications, since that's the only place we use it.If nothing else, this lets us document why we're doing it better since the function pertains specifically to merging packages sources.
Resolves #530