Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pytest GHA workflow #691

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Simplify pytest GHA workflow #691

merged 4 commits into from
Sep 11, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Sep 11, 2024

Description

  • Allocate fewer macos runners by skipping pytest on py3.8
  • Run pytest from repo root to simplify and ensure doctests run

See commit comments for details.

I seem to be having trouble acquiring runners, so hopefully this takes
me below any rate limits I'm hitting. Besides, I run all the unit tests on 3.8
with Ubuntu, as well as 3.8 for the integration tests.
@maresb maresb requested a review from a team as a code owner September 11, 2024 07:49
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit c44f6bd
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/66e167759c8c8e0008a5ce00
😎 Deploy Preview https://deploy-preview-691--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

There was some flakiness of the test suite running in the repo root that
I believe I've cleaned up, so this should no longer be necessary.

Before, doctests were not running.
Now they are prefixed with `tests/`, include doctests, and are sorted
@maresb maresb merged commit 1473122 into conda:main Sep 11, 2024
40 checks passed
@maresb maresb deleted the simplify-pytest-ci branch September 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant