Refactor to make mapping url explicit and eliminate LookupLoader #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This name is much more explicit. Also add a doctest.
This shouldn't make a difference, but it's probably very slightly safer this way.
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, tests could fail because some tests would change the global state of the mapping URL. I changed this to an explicit argument so that we could eliminate the global state and the
_LookupLoaderclass.I also made
mapping_urla required variable (no default). I did this mainly to ensure that all the wires are connected. This could be mildly annoying since it has an obvious default value. We can address this in a future PR, but for now I think explicit is better.