More refactoring of lookup module #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes refactoring easier
This helps refactoring
This was accidentally left over from debugging
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This simplifies the variable scope
This way we can very easily check that the cache is a cache before we start deleting files.
maresb
force-pushed
the
refactor-lookup-again
branch
2 times, most recently
from
559adf3
to
cf3dda7
Compare
maresb
force-pushed
the
refactor-lookup-again
branch
from
a0f5fe2
to
e5c8f36
Compare
maresb
force-pushed
the
refactor-lookup-again
branch
2 times, most recently
from
f04d567
to
68cdf54
Compare
Add diagnostic info about queues
maresb
force-pushed
the
refactor-lookup-again
branch
from
68cdf54
to
5f3c267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further cleanup of the lookup module
A sleep statement was accidentally merged from previous debugging and is removed here.
I added some well-tested caching functionality for the download of the PyPI mapping lookup. (In reality it's not that helpful since the file is only about 1MB and already downloads very quickly. This was a misplaced optimization.)