Add platform validation #94
Conversation
conda_lock/conda_lock.py
Outdated
| @@ -59,6 +62,38 @@ | |||
| CONDA_PKGS_DIRS = None | |||
| DEFAULT_PLATFORMS = ["osx-64", "linux-64", "win-64"] | |||
|
|
|||
| _PLATFORM_MAP = {"osx-64": "darwin", "linux-64": "linux", "win-64": "win"} | |||
There was a problem hiding this comment.
I wasn't quite sure what other types there are (e.g -32 versions). If you provide me with a complete list of what value platform in the lockfile can take, I can reflect that here.
janjagusch
force-pushed
the
add-platform-validation
branch
from
c513e66
to
9acd568
Compare
|
Will finish this PR this week, sorry for taking so long, @mariusvniekerk. :) |
…gusch/conda-lock into add-platform-validation
|
@mariusvniekerk, I have added the custom validation error. ready for review. |
|
Looks like we need to adjust the cli tests for the install to get macos to pass |
|
@janjagusch I've adjusted the logic used here to make use of the subdir detection used in ensureconda which should work correctly |
|
@mariusvniekerk, thanks for helping me with this! i didn't know about the PR looks good to me. is there anything else you want to see before we get this merged? |
Closes #93