-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SHA256 hashes in explicit files #14048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Jul 18, 2024
jaimergp
commented
Jul 18, 2024
CodSpeed Performance ReportMerging #14048 will not alter performanceComparing Summary
|
2 tasks
dholth
reviewed
Aug 9, 2024
dholth
previously approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
jezdez
previously approved these changes
Aug 19, 2024
Co-authored-by: Daniel Holth <[email protected]>
jaimergp
commented
Aug 27, 2024
jezdez
approved these changes
Aug 27, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to make it backwards compatible, but older conda versions will fail with a SHA256. Hopefully the error message is easy to find so I'll mention it in the news file so Google takes folks the right place. Also here for good measure:
If you find an error like this:
You presumably need to update
conda
to the latest version (>=24.9.0), which does have support for the 64-char long SHA256 hashes. I also added acreated-by:
comment to point out which tool and version generated the tool. Thought of adding something liketxtfile-version
or so on, but that'll require a bigger refactor if we want to utilize it.Checklist - did you ...
news
directory (using the template) for the next release's release notes?