Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SHA256 hashes in explicit files #14048

Merged
merged 14 commits into from
Aug 27, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jul 18, 2024

Description

I tried to make it backwards compatible, but older conda versions will fail with a SHA256. Hopefully the error message is easy to find so I'll mention it in the news file so Google takes folks the right place. Also here for good measure:

If you find an error like this:

conda.exceptions.ParseError: Could not parse explicit URL: https://conda.anaconda.org/conda-forge/linux-aarch64/ca-certificates-2024.7.4-hcefe29a_0.conda#562bfc2608d82996a08e5b5b2366ed319a51ace6a2518a004ba672edca75fc23

You presumably need to update conda to the latest version (>=24.9.0), which does have support for the 64-char long SHA256 hashes. I also added a created-by: comment to point out which tool and version generated the tool. Thought of adding something like txtfile-version or so on, but that'll require a bigger refactor if we want to utilize it.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaimergp jaimergp requested a review from a team as a code owner July 18, 2024 11:31
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 18, 2024
conda/misc.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #14048 will not alter performance

Comparing jaimergp:support-explicit-sha256 (523d29b) with main (3a1ed8e)

Summary

✅ 21 untouched benchmarks

conda/cli/main_list.py Outdated Show resolved Hide resolved
dholth
dholth previously approved these changes Aug 9, 2024
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

jezdez
jezdez previously approved these changes Aug 19, 2024
@jaimergp jaimergp dismissed stale reviews from jezdez and dholth via f7fc1b1 August 27, 2024 07:46
conda/cli/main_list.py Outdated Show resolved Hide resolved
@jezdez jezdez merged commit 9463640 into conda:main Aug 27, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
4 participants