acceptance tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustiever
force-pushed
the
accptance-tests
branch
from
582fdd5
to
6168a4d
Compare
hariso
reviewed
Jun 23, 2022
source/acceptance_test.go
Outdated
| is := is.New(t) | ||
| client, err := getClient() | ||
| is.NoErr(err) | ||
| leads, err := addLeads(client, len(records)) |
There was a problem hiding this comment.
Since client is a test client, it looks like you can move addLeads() to Client. That would make the namespace a bit cleaner.
hariso
reviewed
Jun 23, 2022
source/acceptance_test.go
Outdated
Comment on lines
70
to
96
| type AcceptanceTestDriver struct { | ||
| Config AcceptanceSourceTestDriverConfig | ||
| sdk.ConfigurableAcceptanceTestDriver | ||
| } | ||
|
|
||
| // AcceptanceSourceTestDriverConfig contains the configuration for | ||
| // AcceptanceTestDriver. | ||
| type AcceptanceSourceTestDriverConfig struct { | ||
| // Connector is the connector to be tested. | ||
| Connector sdk.Connector | ||
|
|
||
| // SourceConfig should be a valid config for a source connector, reading | ||
| // from the same location as the destination will write to. | ||
| SourceConfig map[string]string | ||
| // DestinationConfig should be a valid config for a destination connector, | ||
| // writing to the same location as the source will read from. | ||
| DestinationConfig map[string]string | ||
|
|
||
| // BeforeTest is executed before each acceptance test. | ||
| BeforeTest func(t *testing.T) | ||
| // AfterTest is executed after each acceptance test. | ||
| AfterTest func(t *testing.T) | ||
|
|
||
| // GoleakOptions will be applied to goleak.VerifyNone. Can be used to | ||
| // suppress false positive goroutine leaks. | ||
| GoleakOptions []goleak.Option | ||
| } |
There was a problem hiding this comment.
@rustiever Sorry for the late response! I'd be grateful if you could remind what was the error you had, which forced you to embed sdk.ConfigurableAcceptanceTestDriver but also copy paste the fields and methods. Other than this, I see no blockers to merging this PR.
hariso
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added acceptance tests
No unit tests are needed since this PR is just refactoring
Quick checks: