This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Update swbt.modal.js to better reflect core jquery.modal.js plugin me… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods and parameters
|
Hey @JPustkuchen, thank you for your PR and sorry for the big delay. Just out of curiosity, what are the benefits of this? Can we expect a better plugin compatibility? |
|
Hi @uehler, sorry I should have better documented this. Modal is used in SW and called, but due to the previous state it simply didn't work and resulted in JS errors where it was called, so this is essential. We're using this patch successfully in production since months. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thods and parameters