🎨 Adopt styler #116
Merged
🎨 Adopt styler #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randycoulman
force-pushed
the
adopt-styler
branch
from
2deaebf
to
fc129c9
Compare
kp-cat
approved these changes
Jan 9, 2024
Adopt the [Styler](https://github.com/adobe/elixir-styler) library, which is an Elixir formatter plugin that imposes some opinionated formatting on the code in place of a number of Credo rules. While I don't always prefer its opinions, I really like have it auto-fix a number of issues, and I find that it's worth the tradeoff to adopt it.
randycoulman
force-pushed
the
adopt-styler
branch
from
fc129c9
to
31f9e44
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 94.28% 94.27% -0.01%
==========================================
Files 33 33
Lines 770 769 -1
==========================================
- Hits 726 725 -1
Misses 44 44 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Adopt the Styler library, which is an Elixir formatter plugin that imposes some opinionated formatting on the code in place of a number of Credo rules.
While I don't always prefer its opinions, I really like having it auto-fix a number of issues, and I find that it's worth the tradeoff to adopt it.
NOTE: This PR is based on #115 because Elixir 1.15 fixes a formatter race condition in the VSCode ElixirLS plugin. In earlier versions of Elixir, the formatter wouldn't always run correctly when saving a file. Since Styler is a formatter plugin, the problem was even more noticeable.
Related issues (only if applicable)
None
Requirement checklist (only if applicable)