Make authentication check for each API method explicit at build time #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4huel
approved these changes
Jan 24, 2020
phansys
added a commit
that referenced
this pull request
Jan 24, 2020
…uild time (phansys)
This PR was merged into the master branch.
Discussion
----------
Since at build time we know if a method requires or not authentication based in their name, build the methods including the resolved value instead of checking that at running time.
**BEFORE**:
```php
// get params array for request
$params = $this->getRequestParamsArray($params);
// check if we've to authenticate
$auth = !in_array('apiinfo.version', self::$anonymousFunctions, true);
// request
return $this->request('apiinfo.version', $params, $arrayKeyProperty, $auth);
```
**AFTER**:
```php
return $this->request('apiinfo.version', $this->getRequestParamsArray($params), $arrayKeyProperty, false);
```
Commits
-------
b012ded Make authentication check for each API method explicit at build time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since at build time we know if a method requires or not authentication based in their name, build the methods including the resolved value instead of checking that at running time.
BEFORE:
AFTER: