build schema registry signed assemblies #1000
Conversation
appveyor.yml
Outdated
| @@ -11,24 +11,28 @@ environment: | |||
|
|
|||
| build_script: | |||
| - cmd: SET STRONG_NAME_OPTIONS=/p:SignAssembly=true;AssemblyOriginatorKeyFile=Confluent.Kafka.snk;PackageId=Confluent.Kafka.StrongName;Title=Confluent.Kafka.StrongName;AssemblyName=Confluent.Kafka.StrongName;BaseOutputPath=bin-sn\ | |||
| - cmd: SET STRONG_NAME_OPTIONS_SR=/p:SignAssembly=true;AssemblyOriginatorKeyFile=Confluent.SchemaRegistry.snk;PackageId=Confluent.SchemaRegistry.StrongName;Title=Confluent.SchemaRegistry.StrongName;AssemblyName=Confluent.SchemaRegistry.StrongName;BaseOutputPath=bin-sn\ | |||
There was a problem hiding this comment.
what's with the trailing backslash?
There was a problem hiding this comment.
i don't know, it's probably not necessary, this is just copying from the Confluent.Kafka case which works.
not for review. there's a lot more to be done here. this is for testing only.
|
following the advice here: https://www.pedrolamas.com/2018/09/11/start-strong-naming-your-assemblies/ , this PR introduces signing on all assemblies distributed via nuget - additionally, the associated unit test assemblies are signed since this acts as a test that all dependencies (including the above) are signed. |
|
note also: confluentinc/avro#16 (comment) this pr resolves: #973 - @longbaochenlong @zhoubo56 , feel free to confirm. |
|
and @edenhill - ready for your OK. |
appveyor.yml
Outdated
| - cmd: IF "%APPVEYOR_REPO_TAG%" == "true" (dotnet pack src/Confluent.SchemaRegistry.Serdes/Confluent.SchemaRegistry.Serdes.csproj -c %CONFIGURATION%) | ||
| - cmd: IF NOT "%APPVEYOR_REPO_TAG%" == "true" (dotnet pack src/Confluent.SchemaRegistry.Serdes/Confluent.SchemaRegistry.Serdes.csproj -c %CONFIGURATION% --version-suffix ci-%APPVEYOR_BUILD_NUMBER%) | ||
|
|
||
| - cmd: IF "%APPVEYOR_REPO_TAG%" == "true" dotnet pack src/Confluent.SchemaRegistry.Serdes/Confluent.SchemaRegistry.Serdes.csproj -c %CONFIGURATION% |
There was a problem hiding this comment.
Inconsistency: the IF statements above have () around the dotnet command
|
@longbaochenlong @zhoubo56 - the 1.2.0-RC1 packages are now on nuget and should all now be strong named. feel free to test this and confirm here. thanks! |
initial PR to test CI build of signed schema registry related assemblies. not yet for review