Fix Deserialize (avro_specific) and improve tests for avro_specific/avro_generic #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixes avro_specific Deserialize method which did not return the right thing (it did not return anything useable). 2. Update tests for (1) - add Deserialize to tests which were only testing DeserializeInto 3. Add Deserialize to avro_generic tests as well.
PrasanthV454
pushed a commit
that referenced
this pull request
Jan 12, 2023
#849) 1. Fixes avro_specific Deserialize method which did not return the right thing (it did not return anything useable). 2. Update tests for (1) - add Deserialize to tests which were only testing DeserializeInto 3. Add Deserialize to avro_generic tests as well.
PrasanthV454
pushed a commit
that referenced
this pull request
Mar 17, 2023
#849) 1. Fixes avro_specific Deserialize method which did not return the right thing (it did not return anything useable). 2. Update tests for (1) - add Deserialize to tests which were only testing DeserializeInto 3. Add Deserialize to avro_generic tests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right thing (it did not return anything useable).
testing DeserializeInto
Addresses #843