Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Protobuf FileDescriptor references #887

Closed
wants to merge 2 commits into from

Conversation

Mrmann87
Copy link
Contributor

@Mrmann87 Mrmann87 commented Nov 3, 2022

Fixes several well known types that were referencing incorrect descriptors.
Additionally, changes the field behavior and source context imports,
which are part of the standard protobuf distribution, to google.golang.org/protobuf
instead of google.golang.org/genproto.

Mrmann87 and others added 2 commits February 20, 2023 21:57
Fixes several well known types were referencing incorrect descriptors.
Additionally, changes the field behavior and source context imports,
which are part of the standard protobuf distribution, to google.golang.org/protobuf
instead of google.golang.org/genproto.
Copy link
Member

@PrasanthV454 PrasanthV454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests on these fields to verify. LGTM.

@milindl
Copy link
Contributor

milindl commented Apr 25, 2023

Looks good to me. I've created a PR on an internal branch for the CI to run, and I'll add a changelog entry. #989

@milindl
Copy link
Contributor

milindl commented May 16, 2023

Closed with merge to master of #989, thanks for this @Mrmann87 !

@cla-assistant
Copy link

cla-assistant bot commented Aug 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ PrasanthV454
❌ Mrmann87
You have signed the CLA already but the status is still pending? Let us recheck it.

@rayokota rayokota closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants