-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin] Add consumer group bindings for KIP 222, 518, 396 (partial) and DeleteConsumerGroups #923
Conversation
74675fa
to
2c4d900
Compare
Added a commit fixing the tests (the tests were not changed while changing the return type of DescribeConsumerGroups) |
DescribeConsumerGroups, ListConsumerGroupOffsets (KIP-222) DeleteConsumerGroups, AlterConsumerGroupOffsets (KIP-396), Allow listing consumer groups per state (KIP-518), Co-authored-by: Emanuele Sabellico <[email protected]> Co-authored-by: Santwana Verma <[email protected]>
also contains some documentation, changelog changes (minor).
16f671d
to
ef0fffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @milindl @vsantwana! I've moved this to an internal branch and opened the PR, so @milindl go on with approving and merging it.
…nd DeleteConsumerGroups (#923) Implement ListConsumerGroups, DescribeConsumerGroups, ListConsumerGroupOffsets (KIP-222), DeleteConsumerGroups, AlterConsumerGroupOffsets (KIP-396), Allow listing consumer groups per state (KIP-518). Co-authored-by: Milind L <[email protected]> Co-authored-by: Santwana Verma <[email protected]>
This includes #852 (by @vsantwana) - the DeleteGroups implementation.
The rest of the bindings are - ListConsumerGroups, DescribeConsumerGroups, AlterConsumerGroupOffsets, and ListConsumerGroupOffsets.