Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] KIP-430: Add authorized operations to describe API #964

Merged
merged 19 commits into from
Oct 19, 2023
Merged

[admin] KIP-430: Add authorized operations to describe API #964

merged 19 commits into from
Oct 19, 2023

Conversation

jainruchir
Copy link
Contributor

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Aug 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@milindl milindl marked this pull request as ready for review September 6, 2023 05:55
@milindl milindl changed the title describe CSG/topics/cluster with authorized ACLoperations [admin] KIP-430: Add authorized operations to describe API Sep 6, 2023
pranavrth
pranavrth requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First Pass comments

kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/testhelpers.go Outdated Show resolved Hide resolved
examples/admin_describe_cluster/admin_describe_cluster.go Outdated Show resolved Hide resolved
examples/admin_describe_topics/admin_describe_topics.go Outdated Show resolved Hide resolved
kafka/integration_test.go Show resolved Hide resolved
kafka/integration_test.go Outdated Show resolved Hide resolved
pranavrth
pranavrth requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just few nits.

kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/integration_test.go Show resolved Hide resolved
kafka/integration_test.go Show resolved Hide resolved
@milindl
Copy link
Contributor

milindl commented Oct 13, 2023

Thanks for the review @pranavrth ! I've addressed all the comment, either through code or replied on them

pranavrth
pranavrth approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@milindl milindl merged commit 6d54227 into master Oct 19, 2023
2 checks passed
@milindl milindl deleted the feature/kip430 branch October 19, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milindl milindl milindl left review comments

@pranavrth pranavrth pranavrth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jainruchir @milindl @pranavrth