-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIP-320: Allow fetchers to detect #968
Conversation
and handle log truncation. Go changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about type, but otherwise okay.
Offset Offset | ||
Metadata *string | ||
Error error | ||
LeaderEpoch *int32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this just be int32, we can use a negative value (-1) similar to C case (as illustrated inif cLeaderEpoch >= 0
).
We can change if it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just for the bindings I've followed the Java client that has an Option so I've put an optional field here, in Python and .NET
@@ -77,6 +77,7 @@ type Message struct { | |||
TimestampType TimestampType | |||
Opaque interface{} | |||
Headers []Header | |||
LeaderEpoch *int32 // LeaderEpoch or nil if not available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto, the thing about this not being a pointer here, too
and handle log truncation. Go changes